Generate social media preview cards for the documentation#132101
Merged
AA-Turner merged 7 commits intopython:mainfrom Apr 5, 2025
Merged
Generate social media preview cards for the documentation#132101AA-Turner merged 7 commits intopython:mainfrom
AA-Turner merged 7 commits intopython:mainfrom
Conversation
AA-Turner
force-pushed
the
docs/ogp_social_cards
branch
from
1ef8448 to
9533953
Compare
hugovk
approved these changes
Apr 5, 2025
Member
hugovk
left a comment
hugovk
left a comment
There was a problem hiding this comment.
As #129120 (comment), we'll only generate images for the docs server, but here's indicative times, and they're very similar to before.
Read the Docs:
macOS:
- Without images: 38s
- With images: 48s
This reverts commit 9533953.
|
Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Sorry, @AA-Turner, I could not cleanly backport this to |
AA-Turner
added a commit
to AA-Turner/cpython
that referenced
this pull request
Apr 10, 2025
…honGH-132101) (cherry picked from commit 561965f) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
|
GH-132344 is a backport of this pull request to the 3.13 branch. |
AA-Turner
added a commit
that referenced
this pull request
Apr 10, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #129120, requires python/docsbuild-scripts#242, closes python/docsbuild-scripts#147.
This generates a
Doc/build/html/_images/social_previews/directory of ~500.pngimages (one per page; ~40MB). Per Hugo's comment in GH-129120, it removes HTML from the page head like:And adds:
A
📚 Documentation preview 📚: https://cpython-previews--132101.org.readthedocs.build/